Fix errors when viewing a Resource in testpage-overlay #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
============================================
- Coverage 74.7% 74.69% -0.02%
+ Complexity 12500 12498 -2
============================================
Files 905 905
Lines 51821 51821
Branches 8713 8713
============================================
- Hits 38713 38706 -7
- Misses 9601 9605 +4
- Partials 3507 3510 +3
Continue to review full report at Codecov.
|
jamesagnew
approved these changes
Oct 31, 2019
|
Thanks for the PR! I have merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added R5 support for testpage-overly. The current fix doesn't work when a Resource on the left side of the page is clicked. It throws error:
Caused by: java.lang.IllegalStateException: Unknown FHIR version: R5
at ca.uhn.fhir.to.Controller.populateModelForResource (Controller.java:298)
This pull request will fix that.
PS> I also had the same fix for R5 in pom.xml and hapi-fhir-testpage-overlay/src/main/java/ca/uhn/fhir/to/BaseController.java but I noticed that they're already fixed :)